Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#381] generic_reaction_wheel checkout #429

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

kevincbruce
Copy link
Contributor

@kevincbruce kevincbruce commented Dec 13, 2024

Updated Reaction Wheel app to have device files for UART control, and then added the checkout application. Have verified the checkout launches and can be commanded in the newest push from this afternoon.

Steps:

  • make clean
  • make debug
  • cd components/generic_reaction_wheel/fsw/standalone/build
    • (mkdir build in the standalone directory if needed, then cd build)
  • make clean
  • cmake .. -DTGTNAME=cpu1
  • make
  • exit
  • make clean
  • make
  • make checkout

The following submodule PRs must be merged and updated first:
nasa-itc/generic_reaction_wheel#9
nasa-itc/generic_adcs#7

Closes #381

…ave device files, and updated ADCS pointers to have the subdirectory for reaction wheel device
@kevincbruce kevincbruce changed the base branch from main to dev December 13, 2024 21:58
@kevincbruce kevincbruce self-assigned this Dec 16, 2024
@kevincbruce kevincbruce added the Feature New Feature label Dec 16, 2024
Fix back to yamcs default
@zlynch2
Copy link

zlynch2 commented Dec 18, 2024

add checkout app to make checkout script

@kevincbruce
Copy link
Contributor Author

add checkout app to make checkout script

@zlynch2 will do. Now that FSS is configed right, waiting for one more review there. Then will merge all that, merge the new dev into this branch, and work from there, so everything is configured right.

@kevincbruce kevincbruce marked this pull request as draft December 18, 2024 21:20
@kevincbruce kevincbruce marked this pull request as ready for review December 19, 2024 19:54
@kevincbruce
Copy link
Contributor Author

I should have fixed everything. Will try to update description with proper instruction. Only main oddity I'm seeing is with Momentum values seeming to flicker to zero sometimes, which may be a sim issue, or a device issue, not quite sure. Guessing SIM since the device is just reading values from there. May be worth a look from @jlucas9 or @msuder to verify (I don't believe I ever touched sim, so if it is there, is a preexisting bug that needs a new issue to close).

@jlucas9 jlucas9 linked an issue Dec 20, 2024 that may be closed by this pull request
@jlucas9
Copy link
Contributor

jlucas9 commented Dec 20, 2024

Checkout not building. Left comment in RW PR.

@kevincbruce
Copy link
Contributor Author

Somehow one line got overwritten, @jlucas9 @zlynch2. Fixing right now

kevincbruce and others added 2 commits December 20, 2024 10:05
… to COSMOS and full config. Fixed minimal config to really be minimal. Update reaction wheel submodule to fix constructor.
Copy link

@dacarter22 dacarter22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout successfully buids and runs, commands are fully functional and responds to user input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generic_reaction_wheel checkout applications
5 participants