-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #7899 fix srp for assignment #7910
base: master
Are you sure you want to change the base?
Conversation
Issue 7899 dom manipulator
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7910 +/- ##
==========================================
- Coverage 57.67% 50.25% -7.43%
==========================================
Files 678 679 +1
Lines 27428 27506 +78
Branches 2691 2691
==========================================
- Hits 15820 13823 -1997
- Misses 11270 13342 +2072
- Partials 338 341 +3
*This pull request uses carry forward flags. Click here to find out more.
... and 209 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Closes #7899
Describe your changes: I am working on a team and trying to contribute to this project. This first contribution is supposed to be small and get us used to creating a pr. The change basically decouples the selection.js module with the DOM manipulation. This also makes selction.js adhere to SRP. We understand this is not a significant change but that is exactly what we we were looking for because of the description of our assignment.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist