Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set view time context when independent time conductor toggled on/off #7954

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davetsay
Copy link
Contributor

Closes #7737

Describe your changes:

observe domainObject.configuration.useIndependentTime in view

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@davetsay davetsay added this to the Target:4.1.0 milestone Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.56%. Comparing base (5be103e) to head (c18c0eb).

Files with missing lines Patch % Lines
src/plugins/plot/MctPlot.vue 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7954      +/-   ##
==========================================
- Coverage   57.57%   57.56%   -0.02%     
==========================================
  Files         678      678              
  Lines       27428    27426       -2     
  Branches     2691     2688       -3     
==========================================
- Hits        15793    15789       -4     
- Misses      11294    11296       +2     
  Partials      341      341              
Flag Coverage Δ
e2e-ci 62.74% <ø> (-0.08%) ⬇️
e2e-full 41.90% <ø> (-0.07%) ⬇️
unit 49.33% <87.50%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
src/plugins/plot/MctPlot.vue 37.16% <87.50%> (-0.04%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be103e...c18c0eb. Read the comment docs.

@davetsay davetsay marked this pull request as ready for review December 10, 2024 17:36
Copy link
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core issue here is not the mode change is propagated to views when the ITC is toggled on/off via the Independent Time Context.

Please see: #7956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plots are respecting independent time context settings, even if not enabled
2 participants