Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default mode and bounds last in time conductor plugin #7964

Open
wants to merge 1 commit into
base: omm-release/5.3.0
Choose a base branch
from

Conversation

mudinthewater
Copy link

@mudinthewater mudinthewater commented Dec 15, 2024

Closes #7963

Describe your changes:

Change just moves the 'setMode' and 'setTimeSystem' functions to be performed last in the time conductor plugin, after the setBounds and setClockOffsets calls, which override the defaults intended.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

…ause the side effect of setClockOffsets and setBounds overrides the defaults.
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (omm-release/5.3.0@5cc3cd4). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             omm-release/5.3.0    #7964   +/-   ##
====================================================
  Coverage                     ?   50.15%           
====================================================
  Files                        ?      680           
  Lines                        ?    27286           
  Branches                     ?     2655           
====================================================
  Hits                         ?    13685           
  Misses                       ?    13271           
  Partials                     ?      330           
Flag Coverage Δ
e2e-full 24.07% <100.00%> (?)
unit 49.27% <100.00%> (?)
Files with missing lines Coverage Δ
src/plugins/timeConductor/plugin.js 78.84% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc3cd4...7f99140. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant