Discrete Event Visualization in Timeline #7967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent-visualization
- Removed in-page `style` defs from ExtendedLinesOverlay.vue; CSS actually located in timeline.scss.
- Improved sizing and style for Marcus Bains ("now") line.
- Removed extraneous padding at bottom of plot view when in Time Strip.
- Added missing header info to timeline.scss.
- CSS refinements.
- Removed bad `}` in TimeSystemAxis.vue. - Removed `.u-contents` from line 129 of ganttChart.e2e.spec.js. - Removed `event-handle` element; not needed. - Changed `__event-wrapper` to not set height explicitly; uses absolute positioning. - Added :before element to event-wrapper for better hit area. - Improved hover styling. - $colorEvent* style constants added to theme constant SCSS files.
- Layout converted to set `min-height` on top-most `c-swimlane` element. Interior containers now use 100% height or absolute positioning. - Removed `c-timeline-holder` from `c-events-tsv` in EventTimelineView.vue; Refactored `c-events-tsv__contents` to be `js-events-tsv` as that was being used as a reference. - New theme constant `eventLineW` sets event lines to be 1px wide for more precision.
…ation' into 7936-add-discrete-event-visualization
| @@ -234,6 +235,7 @@ | |||
| openmct.install(openmct.plugins.Timelist()); | |||
| openmct.install(openmct.plugins.BarChart()); | |||
| openmct.install(openmct.plugins.ScatterPlot()); | |||
| openmct.install(openmct.plugins.EventTimestripPlugin(timeLinePlugin.extendedLinesBus)); | |||
There was a problem hiding this comment.
we need to decide if we want this to be the default plugin in core. Traditionally, we don't add new plugins for e2e tests and run the addInitScript to add the plugin at runtime.
| const eventWrappersContainer = page.locator('.c-events-tsv__container'); | ||
| const eventWrappers = eventWrappersContainer.locator('.c-events-tsv__event-line'); | ||
| const expectedEventWrappersCount = 25; | ||
| await expect(eventWrappers).toHaveCount(expectedEventWrappersCount); |
| @@ -126,7 +126,7 @@ test.describe('Gantt Chart', () => { | |||
| await page.goto(ganttChart.url); | |||
|
|
|||
| // Assert that the Plan's status is displayed as draft | |||
| expect(await page.locator('.u-contents.c-swimlane.is-status--draft').count()).toBe( | |||
| expect(await page.locator('.c-swimlane.is-status--draft').count()).toBe( | |||
There was a problem hiding this comment.
why was this change necessary?
|
|
||
| // turn on extended lines | ||
| await page | ||
| .getByLabel(eventTimelineView.name) |
There was a problem hiding this comment.
this first step in the chainable shouldn't be necessary
unlikelyzero
requested changes
Dec 24, 2024
unlikelyzero
added
notable_change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7936
Describe your changes:
Adds a discrete event visualization for the Time Strip object.
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist