-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated import with numpy array to handle dictionaries with values th… #523
base: dev
Are you sure you want to change the base?
Conversation
…at contain numpy arrays.
Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:
|
Benchmarking Results
|
Codecov Report
@@ Coverage Diff @@
## dev #523 +/- ##
==========================================
- Coverage 80.77% 79.18% -1.59%
==========================================
Files 53 30 -23
Lines 6074 2369 -3705
==========================================
- Hits 4906 1876 -3030
+ Misses 1168 493 -675
... and 23 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, since the DictLikeMatrixWrapper will be completely different in a week! :)
added "from numpy import array" for dictionaries that contain numpy arrays as values.