Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 169 - large file orders #192

Closed
wants to merge 4 commits into from

Conversation

cheyenneland
Copy link

@cheyenneland cheyenneland commented May 15, 2024

GitHub Issue: #169

Description

A short description of the changes in this PR.

Local test steps

Summarize testing and verification you've done. This includes unit tests or testing with specific data

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

📚 Documentation preview 📚: https://stitchee--192.org.readthedocs.build/en/192/

@danielfromearth danielfromearth changed the title merge external changes into feature/issue-169-large-file-orders Feature/issue 169 - large file orders May 15, 2024
@danielfromearth danielfromearth linked an issue May 15, 2024 that may be closed by this pull request
@danielfromearth danielfromearth added the enhancement New feature or request label May 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 21.91%. Comparing base (1af9d29) to head (10c086a).
Report is 1 commits behind head on develop.

Files Patch % Lines
concatenator/stitchee.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #192       +/-   ##
============================================
- Coverage    49.84%   21.91%   -27.94%     
============================================
  Files           11       11               
  Lines          642      648        +6     
============================================
- Hits           320      142      -178     
- Misses         322      506      +184     
Flag Coverage Δ
integration ?
unittests 21.91% <0.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth
Copy link
Collaborator

Closing this issue, because it appears to no longer be needed for working with CERES data. The overarching bundling process splits jobs into manageable groups of files which can be processed by stitchee without such modifications.

@danielfromearth danielfromearth deleted the feature/issue-169-large-file-orders branch September 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of large (such as >1000) file orders
3 participants