Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 198 ordered output #221

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Jul 2, 2024

GitHub Issue: #198

Description

This changes the sorting of datasets from using the concatenation dimension (with a current default of mirror_step), to using a time_variable, which can be specified as an argument to the stitchee() function.

Local test steps

Passed automated CI tests run locally.

Overview of integration done

Passed automated CI integration tests.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

@danielfromearth danielfromearth added bug Something isn't working enhancement New feature or request labels Jul 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.01%. Comparing base (9b28863) to head (391e4e0).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #221      +/-   ##
===========================================
+ Coverage    84.92%   85.01%   +0.09%     
===========================================
  Files           11       11              
  Lines          630      634       +4     
===========================================
+ Hits           535      539       +4     
  Misses          95       95              
Flag Coverage Δ
integration 44.95% <100.00%> (+0.34%) ⬆️
unittests 82.49% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth linked an issue Jul 2, 2024 that may be closed by this pull request
@danielfromearth danielfromearth requested a review from ank1m July 2, 2024 21:26
@danielfromearth danielfromearth self-assigned this Jul 2, 2024
@ank1m
Copy link
Collaborator

ank1m commented Jul 9, 2024

  • Ran multiple request configurations with 6 retries for each configuration
  • Compared 6 retries to each other and every time outputs were "equal" to each other

image
image

@danielfromearth danielfromearth merged commit 09b8099 into develop Jul 9, 2024
5 checks passed
@danielfromearth danielfromearth deleted the feature/issue-198-ordered-output branch July 9, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Un-ordered output due to missing mirror_step variable
3 participants