Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base Doc Site #28

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add Base Doc Site #28

wants to merge 1 commit into from

Conversation

rickdotnet
Copy link
Collaborator

@rickdotnet rickdotnet commented Dec 11, 2024

Targets issue #24, this PR aims to add a foundation for future documentation and examples.

Added:

  • DocFX-based documentation site
    • Matches the structure of NATS.Net Docs .
    • Run locally or hosted on GitHub Pages.
  • DocsExamples project
    • Sits alongside Tests, consistent with NATS.Net docs samples.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.88%. Comparing base (24160d3) to head (1e1c96e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   76.88%   76.88%           
=======================================
  Files          48       48           
  Lines         809      809           
  Branches       63       63           
=======================================
  Hits          622      622           
  Misses        162      162           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickdotnet rickdotnet requested a review from mtmk December 11, 2024 18:27
@rickdotnet
Copy link
Collaborator Author

Figured I'd start with a PR to introduce docs. This will get us a step closer to having more docs/examples.

If you want to publish to GH Pages, I'd suggest a follow-up PR, but I can add those changes if you want to pull the trigger now.

@mtmk
Copy link
Collaborator

mtmk commented Dec 11, 2024

Figured I'd start with a PR to introduce docs. This will get us a step closer to having more docs/examples.

it's a great base already. we can start adding more examples gradually

If you want to publish to GH Pages, I'd suggest a follow-up PR, but I can add those changes if you want to pull the trigger now.

it'd be nice to have it on GH pages you can start if you like I can pick up the settings etc. as we go on or leave it to a follow up if you think it's getting too busy in this PR.

@rickdotnet
Copy link
Collaborator Author

it'd be nice to have it on GH pages

Agree, will start on it in this PR, then.

if you think it's getting too busy

More like, I get busy and forget I had a PR sitting for days. 😂 . I should be able to keep on this one, though. Will take it as far as I can and loop you in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants