[IMPROVED] Increase wait time in tests to prevent failing in CI #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrpio
changed the title
piotrpio
force-pushed
the
fix-flaky-tests
branch
from
d448bd9 to
d761a04
Compare
|
Should not take that long tbh.. Are these failures new? |
|
Also let's flip travis to go 1.19 and go 1.18. |
|
@derekcollison I created this PR as a draft to just play around with how travis behaves, as we have a lot of flaky tests right now and jobs have to be frequently re-triggered. Yeah, in some cases increased timeouts (a bit, not that much) may help, but mostly we are dealing with inconsistent number of running goroutines in travis (for some reason). I'll keep this PR open for now and go back to it in a bit. |
|
ok would change travis over to go 1.19 and go 1.18 regardless. |
|
@derekcollison will do |
wallyqs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.