Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Client stats #1314

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Add Client stats #1314

merged 6 commits into from
Sep 12, 2024

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Sep 12, 2024

Signed-off-by: Tomasz Pietrek [email protected]

Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
@Jarema Jarema changed the title Add connection stats Add Client stats Sep 12, 2024
Signed-off-by: Tomasz Pietrek <[email protected]>
@Jarema Jarema force-pushed the add-connection-stats branch from bd7ec28 to 88de99d Compare September 12, 2024 07:38
Signed-off-by: Tomasz Pietrek <[email protected]>
@Jarema Jarema force-pushed the add-connection-stats branch from ccf55bb to da84812 Compare September 12, 2024 12:28
@Jarema Jarema requested a review from caspervonb September 12, 2024 12:46
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, did you add accidentally from the work you were doing over the weekend tho?

async-nats/src/ext.rs Outdated Show resolved Hide resolved
Signed-off-by: Tomasz Pietrek <[email protected]>
@Jarema Jarema force-pushed the add-connection-stats branch from da84812 to f89a309 Compare September 12, 2024 13:35
@Jarema Jarema requested a review from caspervonb September 12, 2024 16:45
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

async-nats/src/client.rs Outdated Show resolved Hide resolved
Signed-off-by: Tomasz Pietrek <[email protected]>
@Jarema Jarema merged commit 9190ca5 into main Sep 12, 2024
12 checks passed
@Jarema Jarema deleted the add-connection-stats branch September 12, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants