Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check other props for react state change #906

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

malangfox
Copy link
Contributor

Issue

#905

Details

Checks all props when determining whether the panel's state is updated.

@coveralls
Copy link

coveralls commented Dec 13, 2024

Coverage Status

coverage: 82.673% (+0.03%) from 82.639%
when pulling 31c1e3a on malangfox:fix/react-classname-state-change
into d607c30 on naver:master.

@@ -267,7 +267,7 @@ class Flicking extends React.Component<Partial<FlickingProps & FlickingOptions>>
const nextChild = nextChildren[idx];

if (child.key && nextChild.key) {
return child.key === nextChild.key;
return child.key === nextChild.key && Object.keys(child.props).every(key => child.props[key] === nextChild.props[key]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this has no meaning. The cases or objects of children are easy to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants