Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull notification logic; use generalized ding package. #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

c4lliope
Copy link

Hello! I'd been looking around to see how I could easily pair notify-send and https://hexdocs.pm/desktop

Your code inside ExUnitNotifier.Notifiers seemed like a really good basis for a cross-OS notifications pkg.
I expended a couple hours to pull the ExUnit logic back into a single module,
and increased the number of options you can pass along to the handlers / notifiers.

I hope this is a clean approach and can help more people use the logic you prepared.
I'm also eager and happy to share push permissions on the ding library on hex.pm,
since you inspired the code.

This PR is optional in case you'd like to cleanly depend on ding as a dependency.
This codebase can become more minimal, keeping a focus on ExUnit and how the ding options are prepared.
The branch needs to be checked using terminal-notify before merging though,
I checked as much as I could on Linux, and tmux-notifier / notify-send/ terminal-title all look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant