Pull notification logic; use generalized ding
package.
#15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'd been looking around to see how I could easily pair
notify-send
and https://hexdocs.pm/desktopYour code inside
ExUnitNotifier.Notifiers
seemed like a really good basis for a cross-OS notifications pkg.I expended a couple hours to pull the ExUnit logic back into a single module,
and increased the number of options you can pass along to the handlers / notifiers.
I hope this is a clean approach and can help more people use the logic you prepared.
I'm also eager and happy to share push permissions on the
ding
library on hex.pm,since you inspired the code.
This PR is optional in case you'd like to cleanly depend on
ding
as a dependency.This codebase can become more minimal, keeping a focus on ExUnit and how the
ding
options are prepared.The branch needs to be checked using
terminal-notify
before merging though,I checked as much as I could on Linux, and
tmux-notifier
/notify-send
/terminal-title
all look good.