Fix:gui/internal: Restore mg: geo coordinates parsing #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lains
changed the title
jkoan
added a commit
that referenced
this pull request
Feb 4, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous PR, I have implemented google coordinates-type parsing, but this breaks other format parsing. There is a bug and a variable naming is misleading.
The symptom is that trying to retrieve previous bookmarks or destinations will displayed anything anymore.
This PR fixes other parsing formats while still keeping the newly added format as valid (decimal latitude and longitude separated by a comma character, without any space).