Merge core changes from qml-gui-wip #831
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
item_is_poi determines whether if an item is of a POI type or not
Navit drag map moves the map from an origin to a destination
|
I think that the build_android failure is related to https://github.com/navit-gps/navit/pull/827/files#diff-f940ede166f88341829e50c9c345047b |
metalstrolch
requested changes
Aug 20, 2019
| */ | ||
|
|
||
| void navit_drag_map(struct navit *this_, struct point *origin, struct point *destination) { | ||
| update_transformation(this_->trans, origin, destination); |
There was a problem hiding this comment.
Since this shall get a "public" function, I suggest to do some sanity checking here, like aborting if some of the parameters is NULL, issuing some err message if this is not expected. May help future users of this in calling the function right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some core changes in qml-gui-wip that add some new features to core, use this PR to review those changes.