Add isset control to $status to avoid warning

ncstate-delta · Dec 2, 2024 · 5756eeb · 5756eeb
1 parent a09283b
commit 5756eeb
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/settings.php b/settings.php
@@ -174,16 +174,18 @@
     $settings->add($recycleonjoin);
 
     // Only call to the web services and load the setting if the connection is OK
-    if ($status == 'connectionok') {
-        $zoomgrps[] = null;
-        $groupobj = zoom_webservice()->get_groups();
-        foreach ($groupobj->groups as $group) {
-            $zoomgrps[$group->id] = $group->name;
+    if (isset($status)) {
+        if ($status == 'connectionok') {
+            $zoomgrps[] = null;
+            $groupobj = zoom_webservice()->get_groups();
+            foreach ($groupobj->groups as $group) {
+                $zoomgrps[$group->id] = $group->name;
+            }
+            $protectedgrp = new admin_setting_configselect('zoom/protectedgrp',
+                get_string('protectedgrp','mod_zoom'),
+                get_string('protectedgrp_desc','mod_zoom'),0,$zoomgrps);
+            $settings->add($protectedgrp);   
         }
-        $protectedgrp = new admin_setting_configselect('zoom/protectedgrp',
-            get_string('protectedgrp','mod_zoom'),
-            get_string('protectedgrp_desc','mod_zoom'),0,$zoomgrps);
-        $settings->add($protectedgrp);   
     }
 
     // Global settings.