get meeting recordings: use complete recording data #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrchamp
commented
Sep 21, 2023
jrchamp
force-pushed
the
fix/only-newest-occurrence-recordings
branch
3 times, most recently
from
af451a9 to
029af5c
Compare
Plus, only fetch passcodes we need
jrchamp
force-pushed
the
fix/only-newest-occurrence-recordings
branch
from
029af5c to
0f50a72
Compare
jrchamp
commented
Sep 28, 2023
smbader
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were requesting the recordings using the meeting numeric ID, which only returns the recordings for the most recent occurrence of the meeting. Instead, we request the host's recording list, which does not have that limitation. Then we match it up to the Moodle activity and add it to the database.
Fixes #515