Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calendar: skip calendar permissions check #535

Merged
merged 1 commit into from
Oct 26, 2023
Merged

calendar: skip calendar permissions check #535

merged 1 commit into from
Oct 26, 2023

Conversation

jrchamp
Copy link
Collaborator

@jrchamp jrchamp commented Oct 26, 2023

Permissions have already been checked by the calling functions/tasks.

Fixes #534

@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Oct 26, 2023
@jrchamp jrchamp requested a review from a team October 26, 2023 15:22
@jrchamp jrchamp self-assigned this Oct 26, 2023
@jrchamp
calendar: skip calendar permissions check
b197517 
Permissions have already been checked by the calling functions/tasks.
@jrchamp jrchamp force-pushed the fix/calendar-event-permissions branch from a51e189 to b197517 Compare October 26, 2023 17:10
smbader
smbader approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@smbader smbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the user has permission to modify the activity, we should update the calendar event.

@jrchamp jrchamp merged commit a969f57 into main Oct 26, 2023
14 checks passed
@jrchamp jrchamp deleted the fix/calendar-event-permissions branch October 26, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smbader smbader smbader approved these changes

Assignees

@jrchamp jrchamp

Labels
bug Fixes problems or reduces technical debt
Projects
No open projects
Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using admin/cli/restore_backup.php doesn't work with activities with dates
2 participants
@jrchamp @smbader