Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make section headers unique; set initial expanded sections #587

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Make section headers unique; set initial expanded sections #587

merged 1 commit into from
Apr 15, 2024

Conversation

armccoy
Copy link
Contributor

@armccoy armccoy commented Apr 11, 2024

  • Make activity settings page section header IDs unique
  • Set Schedule, Breakout rooms, Security, Media, and Host sections to be expanded on page load.

Fixes #582

@armccoy armccoy added the bug Fixes problems or reduces technical debt label Apr 11, 2024
@armccoy armccoy requested a review from jrchamp April 11, 2024 18:31
@armccoy armccoy self-assigned this Apr 11, 2024
jrchamp
jrchamp approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is excellent 🥳

@jrchamp jrchamp merged commit 5f7a1ce into ncstate-delta:main Apr 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrchamp jrchamp jrchamp approved these changes

Assignees

@armccoy armccoy

Labels
bug Fixes problems or reduces technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The settings section appear to mix action when expanding and collapsing
2 participants
@armccoy @jrchamp