Add IDs to activity details sections and rows #612

armccoy · 2024-08-01T19:32:17Z

Wrap each activity details section (Schedule, Security, Media) in a <div> with a unique ID
Add unique IDs to table rows
Define labels in left table columns as <th>

Fixes #597

jrchamp

Lots of nice improvements! Only a few comments/ideas

view.php

jrchamp

Looks great! One comment and then I believe we can merge.

view.php

…e time. Co-authored-by: Jonathan Champ <[email protected]>

view.php

…currence time.

jrchamp

Looks great! Approving and merging so it can go to integration testing.

Add IDs to activity details sections and rows

2514778

armccoy added the enhancement Adds new functionality label Aug 1, 2024

armccoy requested a review from jrchamp August 1, 2024 19:32

armccoy self-assigned this Aug 1, 2024

view: minor moodle-cs comment fix

095500b

jrchamp reviewed Aug 2, 2024

View reviewed changes

Edits from code review suggestions

7818c62

jrchamp reviewed Sep 12, 2024

View reviewed changes

view.php Outdated Show resolved Hide resolved

Make sure recurring meeting status is displayed before next occurrenc…

d750c05

…e time. Co-authored-by: Jonathan Champ <[email protected]>

jrchamp reviewed Sep 13, 2024

View reviewed changes

view.php Outdated Show resolved Hide resolved

fixup! Make sure recurring meeting status is displayed before next oc…

160cae3

…currence time.

jrchamp approved these changes Sep 19, 2024

View reviewed changes

jrchamp merged commit 8dc452f into main Sep 19, 2024
14 checks passed

jrchamp deleted the enhancement/597-html-ids branch September 19, 2024 15:38

Provide feedback