Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: print git dep missing msg on cargo near new #246

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Nov 7, 2024

while a fuller solution might be done in scope of #238

this pr is a quicker clarification of error
image
image

@dj8yfo dj8yfo marked this pull request as ready for review November 7, 2024 16:30
@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Nov 7, 2024

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Nov 7, 2024

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Do you want to apply for monthly streak? Get 8+ score for a single PR this month and receive boost for race-of-sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 3

Your contribution is much appreciated with a final score of 3!
You have received 33 (30 base + 10% lifetime bonus) Sloth points for this contribution

@frol received 25 Sloth Points for reviewing and scoring this pull request.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link
Contributor

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 3

@frol frol merged commit fa934ed into near:main Nov 8, 2024
17 checks passed
@frol frol mentioned this pull request Nov 8, 2024
dj8yfo pushed a commit that referenced this pull request Nov 14, 2024
## 🤖 New release
* `cargo-near`: 0.11.0 -> 0.12.0 (⚠️ API breaking changes)
* `cargo-near-build`: 0.3.0 -> 0.3.1 (✓ API compatible changes)

### ⚠️ `cargo-near` breaking changes

```
--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field CliNearArgs.teach_me in /tmp/.tmp06Ielo/cargo-near/cargo-near/src/lib.rs:30
  field InteractiveClapContextScopeForNearArgs.teach_me in /tmp/.tmp06Ielo/cargo-near/cargo-near/src/lib.rs:30

--- failure constructible_struct_adds_private_field: struct no longer constructible due to new private field ---

Description:
A struct constructible with a struct literal has a new non-public field. It can no longer be constructed using a struct literal outside of its crate.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/constructible_struct_adds_private_field.ron

Failed in:
  field NearArgs.teach_me in /tmp/.tmp06Ielo/cargo-near/cargo-near/src/lib.rs:35
```

<details><summary><i><b>Changelog</b></i></summary><p>

## `cargo-near`
<blockquote>

##
[0.12.0](cargo-near-v0.11.0...cargo-near-v0.12.0)
- 2024-11-14

### Added

- Added the ability to use the TEACH-ME mode
([#221](#221))

### Other

- Gracefully handle missing `git` on `cargo near new`
([#246](#246))
- update `cargo near new` template `image` and `image_digest`
([#244](#244))
</blockquote>

## `cargo-near-build`
<blockquote>

##
[0.3.1](cargo-near-build-v0.3.0...cargo-near-build-v0.3.1)
- 2024-11-14

### Added

- Added the ability to use the TEACH-ME mode
([#221](#221))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants