Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove]: some unnecessary old implementations for benchmark #3641

Merged

Conversation

nan01ab
Copy link
Contributor

@nan01ab nan01ab commented Dec 22, 2024

Just remove some unnecessary old/duplicated implementations for VM and benchmark.

There is no need to keep previous implementations for several benchmarks.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

remove: some unnecessary old implementations for VM
@nan01ab nan01ab changed the title [Remove]: some unnecessary old implementations [Remove]: some unnecessary old implementations for benchmark Dec 22, 2024
@shargon shargon merged commit 2be2e49 into neo-project:master Dec 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants