-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use quote in backticks rather than escape #1111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have a couple of suggestions but nothing major. Thanks for the quick turnaround!
modules/ROOT/pages/styleguide.adoc
Outdated
@@ -472,7 +472,7 @@ RETURN 'Cypher\'s a nice language', "Mats' quote: \"statement\"" | |||
RETURN "Cypher's a nice language", 'Mats\' quote: "statement"' | |||
---- | |||
|
|||
* Avoid having to use back-ticks to escape characters and keywords. | |||
* Avoid having to use backticks to quote characters and keywords. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Avoid having to use backticks to quote characters and keywords. | |
* Avoid using characters and keywords that require the input to be quoted. |
Feels a little bit more actionable than "avoid having the db force a rule on you"
@@ -16,7 +16,7 @@ The reserved keywords are not permitted to be used as identifiers in the followi | |||
* Function names | |||
* Parameters | |||
|
|||
If any reserved keyword is escaped -- i.e. is encapsulated by backticks ```, such as `++`AND`++` -- it would become a valid identifier in the above contexts. | |||
If any reserved keyword is quoted in backticks (```), such as `++`AND`++`, it would become a valid identifier in the above contexts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add that this isn't recommended, or maybe that is obvious 🤔
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
This is the only mention of escaping with backticks that I found in the Operations manual. Cypher Manual PR: neo4j/docs-cypher#1111
This is the only mention of escaping with backticks that I found in the Operations manual. Cypher Manual PR: neo4j/docs-cypher#1111
Ops Manual PR: neo4j/docs-operations#1959