Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDC documentation #734

Merged
merged 6 commits into from
Sep 25, 2023
Merged

CDC documentation #734

merged 6 commits into from
Sep 25, 2023

Conversation

l-heemann
Copy link
Contributor

@l-heemann l-heemann commented Sep 20, 2023 •
edited
Loading

Documents CDC in cypher manual.

Note: Adds links to unpublished docs-cdc.

@l-heemann l-heemann mentioned this pull request Sep 20, 2023
Merged
@l-heemann
Copy link
Contributor Author

(Publish when public beta, Nodes 2023) CDC Documentation

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@l-heemann l-heemann marked this pull request as ready for review September 20, 2023 14:57
HannesSandberg
HannesSandberg approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@HannesSandberg HannesSandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Can not verify the link but trusting you that it is pointing to the right place

@l-heemann
Copy link
Contributor Author

Looks good to me 👍 Can not verify the link but trusting you that it is pointing to the right place

I am hoping for the docs reviewer to verify it.

JPryce-Aklundh
JPryce-Aklundh reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@JPryce-Aklundh JPryce-Aklundh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, @l-heemann
With regard to the link to the unpublished docs, myself and @recrwplay (on holiday today) will have a look and see if we can get the CDC docs out in time of 5.13. If yes, then no problem.
If no, we may have to find a temporary location to link to.

modules/ROOT/pages/clauses/listing-procedures.adoc Show resolved Hide resolved
modules/ROOT/pages/clauses/listing-procedures.adoc Show resolved Hide resolved
modules/ROOT/pages/clauses/listing-procedures.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc Outdated Show resolved Hide resolved
@l-heemann @JPryce-Aklundh
Apply suggestions from code review
8157ef0 
Co-authored-by: Jens Pryce-Åklundh <[email protected]>
@l-heemann
Copy link
Contributor Author

@JPryce-Aklundh So should we merge this now or do you want to merge it later?

@JPryce-Aklundh
Copy link
Contributor

@l-heemann let's wait with merging until we have figured out the situation with the CDC docs.
This remainder of this PR (i.e. everything apart from the link) is fine now, though.

@ali-ince
Copy link
Contributor

@JPryce-Aklundh I think we now have a plan for cdc docs too: https://neo4j.slack.com/archives/C02JR5E4L/p1695305000000069. Is it ok to merge this now, wdyt?

@JPryce-Aklundh
Copy link
Contributor

@ali-ince - yes, that is fine. I just noticed that the labels that I added as a suggestion does not render well (and are not needed either as they are in the Ops Manual), so I will fix it and then merge.

@JPryce-Aklundh JPryce-Aklundh merged commit b932d6e into neo4j:dev Sep 25, 2023
2 checks passed
@l-heemann l-heemann deleted the cdc_documentation branch October 16, 2023 09:37
JPryce-Aklundh added a commit to JPryce-Aklundh/docs-cypher that referenced this pull request Oct 23, 2023
@l-heemann @JPryce-Aklundh
CDC documentation (neo4j#734)
6c91881 
Documents CDC in cypher manual.

**Note:** Adds links to unpublished
[docs-cdc](https://github.com/neo4j/docs-cdc).

---------

Co-authored-by: Jens Pryce-Åklundh <[email protected]>
@JPryce-Aklundh JPryce-Aklundh mentioned this pull request Oct 23, 2023
Merged
renetapopova added a commit that referenced this pull request Oct 23, 2023
@JPryce-Aklundh @gem-neo4j
@nilsceberg @parnmatt @renetapopova @l-heemann @ali-ince @Hunterness @stefano-ottolenghi @LinneaAndersson
5.13 publish (#768)
69581c9 
Includes the following PRs:

- #676
- #687
- #688
- #722
- #726
- #734
- #735
- #737
- #748
- #749
- #752
- #766

---------

Co-authored-by: Gem Lamont <[email protected]>
Co-authored-by: Nils Ceberg <[email protected]>
Co-authored-by: Matthew Parnell <[email protected]>
Co-authored-by: Matthew Parnell <[email protected]>
Co-authored-by: Reneta Popova <[email protected]>
Co-authored-by: Lasse Heemann <[email protected]>
Co-authored-by: Ali Ince <[email protected]>
Co-authored-by: Therese Magnusson <[email protected]>
Co-authored-by: Stefano Ottolenghi <[email protected]>
Co-authored-by: Therese Magnusson <[email protected]>
Co-authored-by: linneaandersson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPryce-Aklundh JPryce-Aklundh JPryce-Aklundh left review comments

@HannesSandberg HannesSandberg HannesSandberg approved these changes

Assignees

@HannesSandberg HannesSandberg

Labels
5.13 team-cypher-operations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@l-heemann @neo-technology-commit-status-publisher @JPryce-Aklundh @ali-ince @HannesSandberg