Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter database options #735

Merged
merged 11 commits into from
Sep 25, 2023
Merged

Alter database options #735

merged 11 commits into from
Sep 25, 2023

Conversation

ali-ince
Copy link
Contributor

@ali-ince ali-ince commented Sep 20, 2023 •
edited
Loading

Adds content for ALTER DATABASE SET/REMOVE OPTION clauses.

TODO: Update links to actual CDC documentation when published.

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@ali-ince ali-ince requested a review from Hunterness September 20, 2023 09:51
@ali-ince
Copy link
Contributor Author

@Hunterness this is a resurrection of #286, which is now closed due to my fork being detached.

I addressed your only comment, so hope it's ready for a re-review.

@Hunterness Hunterness self-assigned this Sep 20, 2023
@ali-ince
Copy link
Contributor Author

back to you @Hunterness :)

@ali-ince ali-ince requested a review from Hunterness September 21, 2023 09:02
Hunterness
Hunterness approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder for the docs team to not miss porting this over to the operations manual since the code is currently duplicated :)

@renetapopova
Copy link
Contributor

renetapopova commented Sep 21, 2023 •
edited
Loading

This needs to be updated in the Operations manual -> https://trello.com/c/kAUbbH2p/117-document-alter-database

stefano-ottolenghi
stefano-ottolenghi reviewed Sep 21, 2023
View reviewed changes
modules/ROOT/pages/administration/databases.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/administration/databases.adoc
.+ALTER DATABASE SET OPTION+
======

// skip test until we make the change_data_capture feature flag on by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an estimate of when this is supposed to happen, if at all? Just to know when we should remember to remove test-skip.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @l-heemann was looking at enabling it as default in 5.13 but I'm not sure how far he got on that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the feature flag is supposed to default true in 5.13 (cdc goes public beta for Nodes).
PR for the feature flag is here blocked on an issue that is being fixed here

modules/ROOT/pages/administration/databases.adoc Show resolved Hide resolved
modules/ROOT/pages/administration/databases.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/administration/databases.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/administration/databases.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/administration/databases.adoc Outdated Show resolved Hide resolved
stefano-ottolenghi
stefano-ottolenghi approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@stefano-ottolenghi stefano-ottolenghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! @l-heemann is it possible for you to remember to remove the test-skip tags on the relevant examples when CDC is set to true by default, or in alternative to report back here so we remember?

@ali-ince
Copy link
Contributor Author

I'll keep track of it @stefano-ottolenghi.

@stefano-ottolenghi
Copy link
Contributor

@ali-ince shall we wait until CDC links are available + flag is turned on, or did you intend to merge this already?

@ali-ince
Copy link
Contributor Author

If we are not publishing these docs until 5.13 release/announcement, I think we can merge - that will also remove the likelihoods of conflicts.

@stefano-ottolenghi stefano-ottolenghi merged commit 2b9a46d into neo4j:dev Sep 25, 2023
2 checks passed
JPryce-Aklundh pushed a commit to JPryce-Aklundh/docs-cypher that referenced this pull request Oct 23, 2023
@ali-ince @Hunterness
@stefano-ottolenghi @JPryce-Aklundh
Alter database options (neo4j#735)
c43546a 
Adds content for ALTER DATABASE SET/REMOVE OPTION clauses.

TODO: Update links to actual CDC documentation when published.

---------

Co-authored-by: Therese Magnusson <[email protected]>
Co-authored-by: Stefano Ottolenghi <[email protected]>
@JPryce-Aklundh JPryce-Aklundh mentioned this pull request Oct 23, 2023
Merged
renetapopova added a commit that referenced this pull request Oct 23, 2023
@JPryce-Aklundh @gem-neo4j
@nilsceberg @parnmatt @renetapopova @l-heemann @ali-ince @Hunterness @stefano-ottolenghi @LinneaAndersson
5.13 publish (#768)
69581c9 
Includes the following PRs:

- #676
- #687
- #688
- #722
- #726
- #734
- #735
- #737
- #748
- #749
- #752
- #766

---------

Co-authored-by: Gem Lamont <[email protected]>
Co-authored-by: Nils Ceberg <[email protected]>
Co-authored-by: Matthew Parnell <[email protected]>
Co-authored-by: Matthew Parnell <[email protected]>
Co-authored-by: Reneta Popova <[email protected]>
Co-authored-by: Lasse Heemann <[email protected]>
Co-authored-by: Ali Ince <[email protected]>
Co-authored-by: Therese Magnusson <[email protected]>
Co-authored-by: Stefano Ottolenghi <[email protected]>
Co-authored-by: Therese Magnusson <[email protected]>
Co-authored-by: linneaandersson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-heemann l-heemann l-heemann left review comments

@Hunterness Hunterness Hunterness approved these changes

@stefano-ottolenghi stefano-ottolenghi stefano-ottolenghi approved these changes

Assignees

@Hunterness Hunterness

Labels
5.13 team-cypher-operations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ali-ince @neo-technology-commit-status-publisher @renetapopova @stefano-ottolenghi @Hunterness @l-heemann