Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for new normalize function. #784

Merged
merged 7 commits into from
Jan 22, 2024

Conversation

gem-neo4j
Copy link
Contributor

The normalize function normalizes a string based on the normalization form. It is useful for converting unicode representations of characters that look the same to be the same unicode sequence, allowing for easier comparisons.

@neo-technology-commit-status-publisher
Copy link
Collaborator

This PR includes documentation updates.

You can view the updated docs at https://neo4j-docs-cypher-784.surge.sh

@gem-neo4j gem-neo4j force-pushed the dev_add_normalize_function branch 3 times, most recently from 17bfd9d to b971d34 Compare November 27, 2023 13:50
@Lojjs Lojjs self-assigned this Nov 30, 2023
@gem-neo4j gem-neo4j force-pushed the dev_add_normalize_function branch from b971d34 to be471b0 Compare November 30, 2023 10:29
@JPryce-Aklundh JPryce-Aklundh added 5.16 and removed 5.15 labels Dec 6, 2023
@gem-neo4j gem-neo4j force-pushed the dev_add_normalize_function branch from be471b0 to 8fba3ec Compare December 7, 2023 09:56
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor styling thing, but feel free to merge without further look from me

modules/ROOT/pages/functions/index.adoc Outdated Show resolved Hide resolved
@gem-neo4j gem-neo4j force-pushed the dev_add_normalize_function branch from 8fba3ec to a6629e4 Compare January 3, 2024 08:31
@gem-neo4j gem-neo4j added 5.17 and removed 5.16 labels Jan 3, 2024
@gem-neo4j gem-neo4j force-pushed the dev_add_normalize_function branch 2 times, most recently from 7e99bc7 to f5f4ea1 Compare January 12, 2024 07:52
Copy link
Contributor

@JPryce-Aklundh JPryce-Aklundh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gem-neo4j - I tried to give some suggestions to make some parts clearer - let me know if they don't make sense.

modules/ROOT/pages/functions/string.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/functions/string.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/functions/string.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/functions/string.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/functions/string.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/functions/string.adoc Outdated Show resolved Hide resolved
@gem-neo4j gem-neo4j force-pushed the dev_add_normalize_function branch 2 times, most recently from 022c7a7 to 215eb9c Compare January 15, 2024 08:06
@gem-neo4j gem-neo4j marked this pull request as ready for review January 15, 2024 08:07
@gem-neo4j gem-neo4j force-pushed the dev_add_normalize_function branch from 215eb9c to a72ad15 Compare January 17, 2024 08:32
Copy link
Contributor

@JPryce-Aklundh JPryce-Aklundh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @gem-neo4j!
I just have a few suggestions

modules/ROOT/pages/functions/index.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/functions/string.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/functions/string.adoc Outdated Show resolved Hide resolved
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@JPryce-Aklundh JPryce-Aklundh merged commit aadc733 into neo4j:dev Jan 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants