Mention explicitly that unsignedInteger must not be larger than Long.MAX_VALUE. #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Java constant `Long.MAX_VALUE`. =
loveleif
approved these changes
Jan 24, 2024
JPryce-Aklundh
approved these changes
Jan 24, 2024
| @@ -760,6 +760,11 @@ upperBound ::= unsignedInteger | |||
| unsignedInteger ::= [0-9]+ | |||
| ---- | |||
|
|
|||
| [NOTE] | |||
| ==== | |||
| The `unsignedInteger` must not be larger than the Java constant `Long.MAX_VALUE`. | |||
There was a problem hiding this comment.
Maybe this is not necessary, but helpful if readers are both unaware and interested in what the Long.MAX_VALUE is? If you agree - same comment goes for below note.
Suggested change
| The `unsignedInteger` must not be larger than the Java constant `Long.MAX_VALUE`. | |
| The `unsignedInteger` must not be larger than the Java constant `Long.MAX_VALUE` (2^63-1). |
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
JPryce-Aklundh
added
cherry-pick-this-to-5.x
JPryce-Aklundh
pushed a commit
to JPryce-Aklundh/docs-cypher
that referenced
this pull request
Jan 24, 2024
JPryce-Aklundh
added a commit
that referenced
this pull request
Jan 24, 2024
…MAX_VALUE. (#841) (#864) Co-authored-by: Louise Söderström <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.