Fix some tests #850
Merged
Fix some tests #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPryce-Aklundh
added
the
cherry-pick-this-to-5.x
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
JPryce-Aklundh
approved these changes
Jan 29, 2024
JPryce-Aklundh
added a commit
to JPryce-Aklundh/docs-cypher
that referenced
this pull request
Jan 29, 2024
- A setup block was (silently) failing due to an extra trailing comma. With that fixed, the test for the other example failed because `Charlie` was not reported as a string in the asciidoc. - `test-result-skip` is not needed when a result is missing, only when a result is present but _different_ from what the tester would get. - No need to `test-skip` when query parameters are missing: the tester skips automatically. - After a query block, there may only be _one_ result block, either of type `queryresult` or `queryplan`. If there's both of them, the parser will pick the first one, but its internal state will probably also get messed up. - The last two query plans were surely wrong (they didn't have the right return value), while I'm not sure about the first. It may be something that changed in newer releases or IDK, they look pretty similar. --------- Co-authored-by: Jens Pryce-Åklundh <[email protected]>
JPryce-Aklundh
added a commit
that referenced
this pull request
Jan 29, 2024
- A setup block was (silently) failing due to an extra trailing comma. With that fixed, the test for the other example failed because `Charlie` was not reported as a string in the asciidoc. - `test-result-skip` is not needed when a result is missing, only when a result is present but _different_ from what the tester would get. - No need to `test-skip` when query parameters are missing: the tester skips automatically. - After a query block, there may only be _one_ result block, either of type `queryresult` or `queryplan`. If there's both of them, the parser will pick the first one, but its internal state will probably also get messed up. - The last two query plans were surely wrong (they didn't have the right return value), while I'm not sure about the first. It may be something that changed in newer releases or IDK, they look pretty similar. --------- Co-authored-by: Stefano Ottolenghi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Charliewas not reported as a string in the asciidoc.test-result-skipis not needed when a result is missing, only when a result is present but different from what the tester would get.test-skipwhen query parameters are missing: the tester skips automatically.queryresultorqueryplan. If there's both of them, the parser will pick the first one, but its internal state will probably also get messed up.