Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify system database role in seeding #1048

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Clarify system database role in seeding #1048

merged 3 commits into from
Oct 9, 2023

Conversation

fabiim
Copy link
Contributor

@fabiim fabiim commented Sep 21, 2023

No description provided.

@fabiim fabiim added the 4.4 label Sep 21, 2023
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@fabiim fabiim force-pushed the 4-fbot-clarify-sys-database-role branch from 0007923 to 6362129 Compare October 4, 2023 10:22
@fabiim fabiim force-pushed the 4-fbot-clarify-sys-database-role branch from 6362129 to b688501 Compare October 4, 2023 10:25
@fabiim fabiim marked this pull request as ready for review October 4, 2023 10:26
tonbut
tonbut approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@tonbut tonbut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, its confusing to users that restore doesn't create database

renetapopova
renetapopova requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fabiim! I added some editorial suggestions.

modules/ROOT/pages/clustering/seed.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/clustering/seed.adoc Outdated Show resolved Hide resolved
renetapopova
renetapopova approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@renetapopova renetapopova merged commit 9768c8e into neo4j:4.4 Oct 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renetapopova renetapopova renetapopova approved these changes

@tonbut tonbut tonbut approved these changes

Assignees
No one assigned
Labels
4.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabiim @neo-technology-commit-status-publisher @tonbut @renetapopova