Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porting content #1079

Merged

Conversation

AlexicaWright
Copy link
Contributor

No description provided.

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@gfx54b gfx54b self-assigned this Oct 9, 2023
Copy link
Contributor

@JPryce-Aklundh JPryce-Aklundh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @AlexicaWright! I have a few questions/suggestions but overall I think it looks very good.
Also, the commented out lines on the server syntax should be removed, right?

modules/ROOT/pages/clustering/server-syntax.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/clustering/servers.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/clustering/servers.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/clustering/servers.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@JPryce-Aklundh JPryce-Aklundh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just two small suggestions :)

modules/ROOT/pages/clustering/servers.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/clustering/servers.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/clustering/server-syntax.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/clustering/servers.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/clustering/servers.adoc Show resolved Hide resolved
modules/ROOT/pages/clustering/servers.adoc Show resolved Hide resolved
modules/ROOT/pages/clustering/servers.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/clustering/servers.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/clustering/servers.adoc Outdated Show resolved Hide resolved
…lexicaWright/docs-operations into dev-port-clustering-from-cypher-manual
@AlexicaWright AlexicaWright merged commit 39ec3b9 into neo4j:dev Oct 12, 2023
2 checks passed
@renetapopova renetapopova added 5.13 and removed dev labels Oct 23, 2023
renetapopova pushed a commit to renetapopova/docs-operations that referenced this pull request Oct 23, 2023
Co-authored-by: Jens Pryce-Åklundh <[email protected]>
renetapopova added a commit that referenced this pull request Oct 23, 2023
Co-authored-by: Jessica Wright <[email protected]>
Co-authored-by: Jens Pryce-Åklundh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants