Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure Procedures page and add new Details tables #1820

Merged
merged 18 commits into from
Nov 22, 2024
Merged

Restructure Procedures page and add new Details tables #1820

merged 18 commits into from
Nov 22, 2024

Conversation

JPryce-Aklundh
Copy link
Contributor

@JPryce-Aklundh JPryce-Aklundh commented Sep 19, 2024 •
edited by renetapopova
Loading

Once merged, we need to create a redirect for reference/procedures.adoc and the reference/index.adoc.

@JPryce-Aklundh JPryce-Aklundh changed the title Procedure playground Restructure Procedures page and add new Details tables Sep 19, 2024
@renetapopova renetapopova self-assigned this Oct 10, 2024
@renetapopova renetapopova marked this pull request as ready for review October 15, 2024 08:01
mnssn
mnssn approved these changes Oct 24, 2024
View reviewed changes
Copy link

@mnssn mnssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked over the grouping and it looks reasonable to me.

I have only skimmed the signatures. Let me know if this is sufficient, or if you want me to do a more thorough pass.

modules/ROOT/pages/procedures.adoc Show resolved Hide resolved
modules/ROOT/pages/procedures.adoc Show resolved Hide resolved
modules/ROOT/pages/procedures.adoc Outdated Show resolved Hide resolved
@renetapopova
Copy link
Contributor

I have looked over the grouping and it looks reasonable to me.

I have only skimmed the signatures. Let me know if this is sufficient, or if you want me to do a more thorough pass.

Thank you, @mnssn! Everything else should be fine as we test them.

NataliaIvakina
NataliaIvakina reviewed Nov 15, 2024
View reviewed changes
modules/ROOT/pages/procedures.adoc
| *Mode* 3+| DBMS
|===


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, now we don't have a table with all active procedures, do we? We have only 2 tables with removed and deprecated procedures respectively?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct. We have all procedures + deprecated and removed in case users are interested in what's deprecated in particular.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be wrong but our test reports two views: summary (for a table) and detailed (for a list of procedures with descr)
So, now it fails because the table was removed

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova merged commit 5a69402 into neo4j:dev Nov 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaIvakina NataliaIvakina NataliaIvakina left review comments

@renetapopova renetapopova renetapopova left review comments

@mnssn mnssn mnssn approved these changes

Assignees

@renetapopova renetapopova

Labels
5.26 kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JPryce-Aklundh @renetapopova @neo-technology-commit-status-publisher @NataliaIvakina @mnssn