Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow unquoted database names with dot #1948

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Disallow unquoted database names with dot #1948

merged 3 commits into from
Dec 11, 2024

Conversation

l-heemann
Copy link
Contributor

@l-heemann
Copy link
Contributor Author

Remove deprecated syntax for databases / alias names containing '.'

@renetapopova renetapopova self-requested a review November 11, 2024 13:28
renetapopova
renetapopova reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @l-heemann. I added some editorial suggestions.

modules/ROOT/pages/database-administration/standard-databases/naming-databases.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/database-administration/standard-databases/naming-databases.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/database-administration/standard-databases/naming-databases.adoc Outdated Show resolved Hide resolved
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova
Copy link
Contributor

Hey @l-heemann, is this for 5.x, 5.26, or 2025.01?

@l-heemann
Copy link
Contributor Author

l-heemann commented Nov 27, 2024 •
edited
Loading

Hey @l-heemann, is this for 5.x, 5.26, or 2025.01?

This is for Cypher 25, I've started a thread in team-documentation https://neo4j.slack.com/archives/C02JR5E4L/p1731073121053259 a while ago about the need for a separate additions/deprecations/removal track for Cypher versions, but I don't think we got to a conclusion

@l-heemann
Copy link
Contributor Author

I've started a thread in team-documentation

Asked for an update and there seems to be no conclusion yet. It got merged before the 5.26 cutoff in such a way that if you are using neo4j-5.26 with Cypher25 you get the new behaviour, anything other than that you get the old behaviour. I do not know how we are going to represent this in changelogs etc.

@renetapopova renetapopova merged commit 47d8bb4 into neo4j:dev Dec 11, 2024
8 checks passed
renetapopova added a commit that referenced this pull request Dec 24, 2024
@renetapopova
Revert "Disallow unquoted database names with dot (#1948)"
dc461fd 
This reverts commit 47d8bb4.
@renetapopova renetapopova mentioned this pull request Dec 24, 2024
Merged
renetapopova added a commit that referenced this pull request Dec 24, 2024
@renetapopova
Revert "Disallow unquoted database names with dot" (#2031)
091f5f3 
Reverts #1948
Cypher 25 will not be released with 2025.01. I'll create a separate PR
with this feature.
@renetapopova renetapopova mentioned this pull request Dec 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renetapopova renetapopova renetapopova approved these changes

Assignees
No one assigned
Labels
2025.01 Cypher 25 team-cypher-operations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l-heemann @neo-technology-commit-status-publisher @renetapopova