Allow database names to start with a digit #1952
Conversation
mnd999
force-pushed
the
document-databases-start-digit
branch
from
10b2f8b to
8728ba8
Compare
|
Updated to add a note to say which release this was changed. |
modules/ROOT/pages/database-administration/standard-databases/naming-databases.adoc
Outdated
Show resolved
Hide resolved
| @@ -812,7 +812,8 @@ m|+++0+++ | |||
| |Description | |||
| a|Names of the databases allowed on this server; all others are denied. Empty means all are allowed. This configuration can be overridden when enabling the server or altered at runtime without changing this setting. Exclusive with `server.initial_denied_databases`. | |||
| |Valid values | |||
| a|A comma-separated set where each element is a valid database name containing only alphabetic characters, numbers, dots, and dashes with a length between 3 and 63 characters, starting with an alphabetic character but not with the name `system`. | |||
| a|A comma-separated set where each element is a valid database name. | |||
| Database naming rules are described in xref:database-administration/standard-databases/naming-databases.adoc[Naming rules for databases] | |||
There was a problem hiding this comment.
There is a build error regarding this file, I guess something with this line?
There was a problem hiding this comment.
Oh, it seems like they validate the config descriptions against the database, so I can't do this:
== Docs ==
A valid database name. Database naming rules are described in Naming rules for databases
== Neo4j ==
A valid database name containing only alphabetic characters, numbers, dots, and dashes with a length between 3 and 63 characters, starting with an alphabetic character but not with the name system.
I guess I need to go back into the monorepo and update them all there 😮💨
There was a problem hiding this comment.
Actually that doesn't make much sense to have "from version ..." in the database core repo, since that always knows what version it is. Maybe I just need to add the digits there and leave it at that.
There was a problem hiding this comment.
We can add labels in the docs description as labels are ignored by the test if by "from version .." you mean when this change is introduced.
There was a problem hiding this comment.
mnd999
force-pushed
the
document-databases-start-digit
branch
from
cf76db2 to
e5fb5e0
Compare
modules/ROOT/pages/database-administration/standard-databases/naming-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/standard-databases/naming-databases.adoc
Outdated
Show resolved
Hide resolved
mnd999
force-pushed
the
document-databases-start-digit
branch
from
70b19f6 to
e20cb3a
Compare
We have relaxed the database naming rules to allow a database name to start with a digit. Update docs to reflect this.
…naming-databases.adoc Co-authored-by: Reneta Popova <[email protected]>
mnd999
force-pushed
the
document-databases-start-digit
branch
from
e20cb3a to
6636e74
Compare
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
|
@renetapopova I'm not sure how to fix this test. The validation message is updated on the |
I'll take it from here. Don't need to worry about it. Thanks, @mnd999 |
We have relaxed the database naming rules to allow a database name to start with a digit. Update docs to reflect this.
See also https://github.com/neo-technology/neo4j/pull/28262