Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tie up the Database internals section with the v4.4 #1973

Merged
merged 9 commits into from
Dec 11, 2024

Conversation

NataliaIvakina
Copy link
Contributor

@NataliaIvakina NataliaIvakina commented Nov 20, 2024

The Database internals section was created in 5.x. This means we don't have anything similar in the v4.4 docs.
Some of the pages can be linked to the Java Reference 4.4 and its section Transaction management.

Copy link
Contributor

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I haven't tried the page aliases. I trust you that they work.

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@NataliaIvakina
Copy link
Contributor Author

NataliaIvakina commented Dec 10, 2024

I spent a lot of time experimenting with page-aliases for the Store formats page. However, I failed to tie it up to the page Display store information in 4.4. The problem is the following: the page Display store information is located at the same place in 4.4 and 5 versions. When I define the page-aliases attribute to use the 4.4 build (4.4@operations-manual:tool/neo4j-admin/neo4j-admin-store-info.adoc), the version selector doesn't connect this page to the target page (Store formats) because the resource ID, assigned to page-aliases, works in xrefs. Thus, there is no benefit in using the page-aliases attribute. I suggest adding a note directing users to the needed page.

@NataliaIvakina NataliaIvakina merged commit 74abc24 into neo4j:dev Dec 11, 2024
8 checks passed
@NataliaIvakina NataliaIvakina deleted the dev-add-links branch December 11, 2024 07:19
NataliaIvakina added a commit to NataliaIvakina/docs-operations that referenced this pull request Dec 11, 2024
The _Database internals_ section was created in 5.x. This means we don't
have anything similar in the v4.4 docs.
Some of the pages can be linked to the Java Reference 4.4 and its
section _Transaction management_.
NataliaIvakina added a commit that referenced this pull request Dec 11, 2024
The _Database internals_ section was created in 5.x. This means we don't
have anything similar in the v4.4 docs.
Some of the pages can be linked to the Java Reference 4.4 and its
section _Transaction management_.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants