-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immutable roles #1984
Immutable roles #1984
Conversation
9cbc1fb
to
2bf6192
Compare
2bf6192
to
e54b57c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits. Also I think the convention is one sentence per line so you might need to reformat in a few places.
modules/ROOT/pages/authentication-authorization/manage-privileges.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/manage-roles.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/manage-roles.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/privileges-and-roles-immutable.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/manage-roles.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/privileges-and-roles-immutable.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/privileges-and-roles-immutable.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Dixon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay to me now
modules/ROOT/pages/authentication-authorization/privileges-and-roles-immutable.adoc
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/privileges-and-roles-immutable.adoc
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/privileges-and-roles-immutable.adoc
Show resolved
Hide resolved
be7ad5a
to
a5a8343
Compare
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
[[access-control-immutable-roles]] | ||
=== Immutable roles | ||
Immutable roles are roles which cannot be modified in the usual way. | ||
This means they cannot be created, renamed, dropped, or have privileges granted to or revoked from them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This contradicts the above commands, for example, CREATE [IMMUTABLE] ROLE name AS COPY OF otherName
or CREATE OR REPLACE [IMMUTABLE] ROLE name [AS COPY OF otherName]
, etc.
Replaced by #2001 |
Replaces #1984 --------- Co-authored-by: Phil Wright <[email protected]>
adds instructions and examples for how to administer immutable roles which are to be used in conjunction with immutable privileges.
Combines the immutable roles docs with those for immutable privileges because the two are part of the same feature.