Update documentation on custom Advancement criteria #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChampionAsh5357
requested changes
Jan 15, 2024
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
Deploying with Cloudflare Pages
|
ChampionAsh5357
requested changes
Jan 15, 2024
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
|
I'm gonna request changing all the headers from == and -- to # and ## while you're at it. |
ChampionAsh5357
approved these changes
Jan 15, 2024
XFactHD
approved these changes
Jan 15, 2024
IchHabeHunger54
approved these changes
Jan 16, 2024
neoforged-pages-deployments
bot
deployed
to
neoforged-docs-previews (Preview)
83 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the vanilla code for registering new Advancement criteria changed (I'm presuming in 1.20, but I hadn't much used it earlier). This includes both the names of classes and pretty large shifts from the currently documented requirements, such as no longer dealing directly with JSON objects.
I believe this also should check one box of #20
Preview URL: https://pr-45.neoforged-docs-previews.pages.dev