Improve hasErrors implementations (#159)

neoforged · Jun 3, 2024 · 1b6af92 · 1b6af92
1 parent 1ca21b0
commit 1b6af92
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/loader/src/main/java/net/neoforged/fml/ModLoader.java b/loader/src/main/java/net/neoforged/fml/ModLoader.java
@@ -392,7 +392,7 @@ public static <T extends Event & IModBusEvent> void postEventWithWrapInModOrder(
      *         If you are running in a Mixin before mod loading has actually started, check {@link LoadingModList#hasErrors()} instead.
      */
     public static boolean hasErrors() {
-        return loadingIssues.stream().anyMatch(issue -> issue.severity() == ModLoadingIssue.Severity.ERROR);
+        return !loadingIssues.isEmpty() && loadingIssues.stream().anyMatch(issue -> issue.severity() == ModLoadingIssue.Severity.ERROR);
     }
 
     @ApiStatus.Internal

diff --git a/loader/src/main/java/net/neoforged/fml/loading/LoadingModList.java b/loader/src/main/java/net/neoforged/fml/loading/LoadingModList.java
@@ -170,7 +170,7 @@ public List<ModInfo> getDependencies(IModInfo mod) {
     }
 
     public boolean hasErrors() {
-        return modLoadingIssues.stream().noneMatch(issue -> issue.severity() == ModLoadingIssue.Severity.ERROR);
+        return !modLoadingIssues.isEmpty() && modLoadingIssues.stream().anyMatch(issue -> issue.severity() == ModLoadingIssue.Severity.ERROR);
     }
 
     public List<ModLoadingIssue> getModLoadingIssues() {