Add a Spotless plugin #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sciwhiz12
requested changes
Feb 9, 2024
src/main/groovy/net/neoforged/gradleutils/spotless/SpotlessPlugin.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/net/neoforged/gradleutils/spotless/SpotlessUtilsExtension.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/net/neoforged/gradleutils/spotless/SpotlessUtilsExtension.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/net/neoforged/gradleutils/spotless/ExtractSpotlessConfiguration.groovy
Outdated
Show resolved
Hide resolved
Technici4n
reviewed
Feb 9, 2024
src/spotless/groovy/net/neoforged/gradleutils/spotless/SpotlessUtilsExtension.groovy
Outdated
Show resolved
Hide resolved
Technici4n
reviewed
Feb 9, 2024
src/spotless/groovy/net/neoforged/gradleutils/spotless/SpotlessUtilsExtension.groovy
Show resolved
Hide resolved
src/spotless/groovy/net/neoforged/gradleutils/spotless/SpotlessUtilsExtension.groovy
Show resolved
Hide resolved
sciwhiz12
requested changes
Feb 11, 2024
README.md
Outdated
|
|
||
| The `net.neoforged.gradleutils.spotless` plugin provides integration (a formatter configuration) with Spotless. | ||
|
|
||
| This plugin provides a `spotlessUtils` extension which has a `configure` method that can be called with the `spotless` extension to configure Spotless and use the formatter configuration provided by GradleUtils. |
There was a problem hiding this comment.
Provide an example, for clarity.
|
Also we should probably make a note here: spotless for Gradle requires the Gradle runtime to be running in java 17 |
sciwhiz12
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
net.neoforged.gradleutils.spotlessplugin that will configure spotless to use a shared formatter config.See https://github.com/neoforged/NeoForge/blob/932773f5194811609b03edeaa9b0c0f6a7d3a516/codeformat/formatter-config.xml