Enable Profile Icon

[Ecdcaeb]

enable profile icon of base64

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

[shartte]

What is this trying to solve or fix?

[Ecdcaeb]

What is this trying to solve or fix?

Although it is not currently required by NeoForge, this PR is still submitted for the following reasons:

1. Support the legacy operations https://github.com/neoforged/NeoForge/blob/1.16.x/build.gradle#L669
2. Since we are currently using entry key="installer.window.title">%s Installer</entry> instead of entry key="installer.window.title">NeoForge Installer</entry>, this means that LegacyInstaller is not only designed for NeoForge. It is also necessary to try to obtain icons from the profile instead of just hard-code them.

[shartte]

What is this trying to solve or fix?

Although it is not currently required by NeoForge, this PR is still submitted for the following reasons:

1. Support the legacy operations https://github.com/neoforged/NeoForge/blob/1.16.x/build.gradle#L669

2. Since we are currently using `entry key="installer.window.title">%s Installer</entry>` instead of `entry key="installer.window.title">NeoForge Installer</entry>`, this means that LegacyInstaller is not only designed for NeoForge. It is also necessary to try to obtain icons from the profile instead of just hard-code them.

1. We don't do NeoForge before 1.20.1, we don't have a need for supporting installer profiles of earlier versions in the latest installer (since the old version would not use it anyway)
2. You coud just overwrite the logo in the final jar file with another logo if you wanted to, would that solve what you want to do?

[Ecdcaeb]

What is this trying to solve or fix?

Although it is not currently required by NeoForge, this PR is still submitted for the following reasons:

1. Support the legacy operations https://github.com/neoforged/NeoForge/blob/1.16.x/build.gradle#L669

2. Since we are currently using `entry key="installer.window.title">%s Installer</entry>` instead of `entry key="installer.window.title">NeoForge Installer</entry>`, this means that LegacyInstaller is not only designed for NeoForge. It is also necessary to try to obtain icons from the profile instead of just hard-code them.

1. We don't do NeoForge before 1.20.1, we don't have a need for supporting installer profiles of earlier versions in the latest installer (since the old version would not use it anyway)
2. You coud just overwrite the logo in the final jar file with another logo if you wanted to, would that solve what you want to do?

Thank you for your help. There is nothing other than the file name.