Remove separate eye height field from EntityEvent.Size

[sciwhiz12]

This PR resolves #1170 by removing the separate eye height field (and getter/setter) from EntityEvent.Size, and using the eye height stored in the EntityDimensions object instead.

Previously, the eye height was stored separately from the EntityDimensions, which explains why the event treated it separately. But in one of the 1.20 releases (I believe 1.20.5), the eye height is now part of the EntityDimensions object.

This PR also removes the now-unused Entity#getEyeHeightAccess accessor, since the eye height is now longer calculated by the getEyeHeight method it was accessing, and cleans up the javadoc for EntityEvent.Size.

---

FYI, @robotgryphon, one of us will have to update the javadoc for the event to use isAddedToLevel() per your PR #1166, depending on which one of us gets merged first.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: dc039d19d03c3d4a4e39c33b722db2d665ec8671.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:21.0.39-beta-pr-1171-1.21-GH-1170-entityevent-size-eye-height
• 📦 net.neoforged:testframework:21.0.39-beta-pr-1171-1.21-GH-1170-entityevent-size-eye-height

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1171' // https://github.com/neoforged/NeoForge/pull/1171
        url 'https://prmaven.neoforged.net/NeoForge/pr1171'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1171.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1171
cd NeoForge-pr1171
curl -L https://prmaven.neoforged.net/NeoForge/pr1171/net/neoforged/neoforge/21.0.39-beta-pr-1171-1.21-GH-1170-entityevent-size-eye-height/mdk-pr1171.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[robotgryphon]

Change itself appears fine. Curious about the relationship between the new size attributes, whether the Entit0Eventy.Size event is still useful or fired when that attribute changes?

[sciwhiz12]

When the entity scale attribute changes (in a living entity), the living entity tick will notice the change (as it stores the previous scale value as the appliedScale field) and cause a refresh of the entity dimensions through refreshDimensions().

The value of the scale attribute is used in LivingEntity#getDimensions(Pose) (among other places), which is called by refreshDimensions() to determine the new entity dimensions, which then triggers the EntityEvent.Size.

Therefore, the event is still useful to control the final dimensions of the entity, but I believe developers will need to apply the scale value manually (from getScale()) if they are recreating the entity dimensions from the entity type's default EntityDimensions.

[neoforged-compatibility-checks]

@sciwhiz12, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: dc039d19d03c3d4a4e39c33b722db2d665ec8671.

Compatibility checks

neoforge (:neoforge)

• net/neoforged/neoforge/event/entity/EntityEvent$Size
  • getOldEyeHeight()F: ❗ API method was removed
  • setNewEyeHeight(F)V: ❗ API method was removed
  • <init>(Lnet/minecraft/world/entity/Entity;Lnet/minecraft/world/entity/Pose;Lnet/minecraft/world/entity/EntityDimensions;F)V: ❗ API method was removed
  • <init>(Lnet/minecraft/world/entity/Entity;Lnet/minecraft/world/entity/Pose;Lnet/minecraft/world/entity/EntityDimensions;Lnet/minecraft/world/entity/EntityDimensions;FF)V: ❗ API method was removed
  • setNewSize(Lnet/minecraft/world/entity/EntityDimensions;Z)V: ❗ API method was removed
  • getNewEyeHeight()F: ❗ API method was removed
• net/minecraft/world/entity/Entity
  • getEyeHeightAccess(Lnet/minecraft/world/entity/Pose;)F: ❗ API method was removed
• net/neoforged/neoforge/event/EventHooks
  • getEntitySizeForge(Lnet/minecraft/world/entity/Entity;Lnet/minecraft/world/entity/Pose;Lnet/minecraft/world/entity/EntityDimensions;F)Lnet/neoforged/neoforge/event/entity/EntityEvent$Size;: ❗ API method was removed
  • getEntitySizeForge(Lnet/minecraft/world/entity/Entity;Lnet/minecraft/world/entity/Pose;Lnet/minecraft/world/entity/EntityDimensions;Lnet/minecraft/world/entity/EntityDimensions;F)Lnet/neoforged/neoforge/event/entity/EntityEvent$Size;: ❗ API method was removed