Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add immaculate rule that forbits @NotNull in patches #1785

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

Technici4n
Copy link
Member

Closes #1720.

@neoforged-automation neoforged-automation bot added the 1.21.4 Targeted at Minecraft 1.21.4 label Dec 17, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Dec 17, 2024

  • Publish PR to GitHub Packages

Last commit published: d0dd6b38e366916881ccb7080fbc4383205a7520.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1785' // https://github.com/neoforged/NeoForge/pull/1785
        url 'https://prmaven.neoforged.net/NeoForge/pr1785'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1785.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1785
cd NeoForge-pr1785
curl -L https://prmaven.neoforged.net/NeoForge/pr1785/net/neoforged/neoforge/21.4.33-beta-pr-1785-fix-1720/mdk-pr1785.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

build.gradle Outdated Show resolved Hide resolved
@Technici4n Technici4n requested a review from XFactHD December 18, 2024 09:55
@Technici4n Technici4n merged commit f64d2c7 into neoforged:1.21.x Dec 18, 2024
6 checks passed
@Technici4n Technici4n deleted the fix-1720 branch December 18, 2024 21:48
shartte added a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add spotless rule to prevent @NotNull in patches
2 participants