-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only fire gather data events for the mods enabled #1806
base: 1.21.x
Are you sure you want to change the base?
Conversation
Previously, all mods would receive the event and register to the data generator and the cli args will simply decide which generator to run. This can cause issues when dependencies ship their datagen which requires other dependencies as you'll hit CNFEs. This PR changes it so that only the requested mods get the event posted.
Last commit published: 8558596bb987d28cec0625788d3120fda5f8b8ea. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1806' // https://github.com/neoforged/NeoForge/pull/1806
url 'https://prmaven.neoforged.net/NeoForge/pr1806'
content {
includeModule('net.neoforged', 'neoforge')
includeModule('net.neoforged', 'testframework')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1806
cd NeoForge-pr1806
curl -L https://prmaven.neoforged.net/NeoForge/pr1806/net/neoforged/neoforge/21.4.48-beta-pr-1806-restricted-gatherdataevent/mdk-pr1806.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
@Matyrobbrt, this PR introduces breaking changes.
|
@Matyrobbrt, this pull request has conflicts, please resolve them for this PR to move forward. |
Previously, all mods would receive the event and register to the data generator and the cli args will simply decide which generator to run. This can cause issues when dependencies ship their datagen which requires other dependencies as you'll hit CNFEs.
This PR changes it so that only the requested mods get the event posted.