Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only fire gather data events for the mods enabled #1806

Open
wants to merge 1 commit into
base: 1.21.x
Choose a base branch
from

Conversation

Matyrobbrt
Copy link
Member

Previously, all mods would receive the event and register to the data generator and the cli args will simply decide which generator to run. This can cause issues when dependencies ship their datagen which requires other dependencies as you'll hit CNFEs.

This PR changes it so that only the requested mods get the event posted.

Previously, all mods would receive the event and register to the data generator and the cli args will simply decide which generator to run. This can cause issues when dependencies ship their datagen which requires other dependencies as you'll hit CNFEs.

This PR changes it so that only the requested mods get the event posted.
@Matyrobbrt Matyrobbrt added the enhancement New (or improvement to existing) feature or request label Dec 28, 2024
@neoforged-automation neoforged-automation bot added the 1.21.4 Targeted at Minecraft 1.21.4 label Dec 28, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Dec 28, 2024

  • Publish PR to GitHub Packages

Last commit published: 8558596bb987d28cec0625788d3120fda5f8b8ea.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1806' // https://github.com/neoforged/NeoForge/pull/1806
        url 'https://prmaven.neoforged.net/NeoForge/pr1806'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1806.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1806
cd NeoForge-pr1806
curl -L https://prmaven.neoforged.net/NeoForge/pr1806/net/neoforged/neoforge/21.4.48-beta-pr-1806-restricted-gatherdataevent/mdk-pr1806.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@neoforged-compatibility-checks

@Matyrobbrt, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: 8558596bb987d28cec0625788d3120fda5f8b8ea.

neoforge (:neoforge)

  • net/neoforged/neoforge/data/event/GatherDataEvent$DataGeneratorConfig
    • makeGenerator(Ljava/util/function/Function;Z)Lnet/minecraft/data/DataGenerator;: ❗ API method was removed

@neoforged-automation
Copy link

@Matyrobbrt, this pull request has conflicts, please resolve them for this PR to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 enhancement New (or improvement to existing) feature or request needs rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants