Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: 4305 Mark *Serialized* commands @internal #4757

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Nov 17, 2023

Resolves: #4305

they should normally not be called from user land.

Especially because in some cases the command validation is not perfect for the Serialized commands and we only validate the "main" commands fully.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

they should normally not be called from user land.
@mhsdesign mhsdesign merged commit 3a37216 into neos:9.0 Nov 17, 2023
6 checks passed
@mhsdesign mhsdesign deleted the task/markSerializedCommandsAsInternal branch November 17, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9.0 Make CreateNodeAggregateWithNodeAndSerializedProperties internal?
2 participants