!!! FEATURE: Drop twitter bootstrap dependency #5409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only used it in one place and it’s basically not maintained anymore. With this change the bootstrap library that is required for the media browser is moved to the media browser and therefore no other dependency is left. This might be breaking for projects that use the bootstrap viewhelper or library and didn’t add they own dependency. Resolves: #5408
Sebobo
requested review from
kitsunet,
dlubitz,
mhsdesign and
markusguenther
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only used it in one place and it’s basically not maintained anymore. With this change the bootstrap library that is required for the media browser is moved to the media browser and therefore no other dependency is left.
This might be breaking for projects that use the bootstrap viewhelper or library and didn’t add they own dependency.
Resolves: #5408
Upgrade instructions
If you used some functionality of the bootstrap package you need to add the dependency `"neos/twitter-bootstrap": "^3.0.6" to your own project.