Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Offline sign with complex transaction #3291

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: Offline sign with complex transaction #3291

wants to merge 3 commits into from

Conversation

devchenyan
Copy link
Collaborator

issue: Magickbase/neuron-public-issues#429

Screen-2025-01-06-004004.mp4

@yanguoyu
Copy link
Collaborator

yanguoyu commented Jan 5, 2025 •
edited
Loading

@Danie0918 Is this result expected?

On the other hand, I didn't get the design for this issue.

@Danie0918
Copy link
Collaborator

#3260

This popup is as expected and addresses Neuron's inability to sign transactions with unrecognized lock scripts.

@devchenyan devchenyan mentioned this pull request Jan 7, 2025
Open
@yanguoyu
Copy link
Collaborator

yanguoyu commented Jan 7, 2025

#3260

This popup is as expected and addresses Neuron's inability to sign transactions with unrecognized lock scripts.

From #3260, if we skip the unknown lock script. Neuron can sing successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Awaiting requested review from Keith-CY

@homura homura Awaiting requested review from homura

@yanguoyu yanguoyu Awaiting requested review from yanguoyu

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devchenyan @yanguoyu @Danie0918