-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bouhadjar sequence learning network tutorial #1026
Conversation
Bencher Report
Click to view all benchmark results
|
It seems as though the second line in the following snippet from the notebook causes an extreme memory consumption: connections = nest.GetConnections(synapse_model=...)
connections.set({'Wmin': connections.weight}) There are around 165000 connections. Edit: spun off to nest/nest-simulator#3359. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this excellent tutorial! I have a few minor comments:
- When you describe the different terms in the STDP rule in the text, could you refer to the equation by number? For example, the second term on the right-hand side in (1)...
- Any reason behind setting the number of threads to 1?
- Under "Generating code with NESTML", do we need the
try
andexcept
?- Remove the following lines
"""module_name = "/tmp/nestml_target_68digoes/nestml_27fd8d9de14b408f9e6181b2f2310d41_module.so"
neuron_model_name = "iaf_psc_exp_nonlineardendrite_neuron_nestml__with_stdsp_synapse_nestml"
synapse_model_name = "stdsp_synapse_nestml__with_iaf_psc_exp_nonlineardendrite_neuron_nestml" """
- The fig just before
Experiment 2
is a bit hard to read. Can the three panels be a bit further apart?
doc/tutorials/sequence_learning/iaf_psc_exp_nonlineardendrite_neuron.nestml
Outdated
Show resolved
Hide resolved
doc/tutorials/sequence_learning/iaf_psc_exp_nonlineardendrite_neuron.nestml
Outdated
Show resolved
Hide resolved
doc/tutorials/sequence_learning/iaf_psc_exp_nonlineardendrite_neuron.nestml
Show resolved
Hide resolved
doc/tutorials/sequence_learning/iaf_psc_exp_nonlineardendrite_neuron.nestml
Outdated
Show resolved
Hide resolved
@pnbabu: much obliged for the review! I have cleaned up the notebook and the neuron model; this should address all your comments. |
I have created a PR to your fork @clinssen with an update of the notebook. Remained to be done:
|
Thanks very much for the review! The latest changes should address all your comments.
Done.
Done.
numpy is constrained to be >= 1.8.2. Only sympy is limited (to <1.11) but this should soon be amended (nest/ode-toolbox#77 (comment)).
This has been changed starting from NEST 3.7 (I noticed from the log messages in the notebook that you are using 3.6). Please let me know if this addresses your comments; much obliged! |
Thank you for the review! |
Should be merged after #1027.