79 update config README #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add sources for feature and reweighting datasets - add required data attribution statements - remove 'S3 file' column for brevity and easier maintenance - the path is too changeable and it is already recorded in the base config file - add new 'feature' column to feature datasets table - update config key for NRS_households (from NRS_dwellings) to reflect actual dataset- we use the household not dwelling counts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79
Description
Add new data sources and attributions to config/README
Instructions for Reviewer
During your review, along with general review of readability /clarity etc, please could you check:
S3 filecolumn. I removed it because I don't think it added value as all the S3 paths can already be found in theconfig/base.yamland also because they are so changeable it would create unnecessary work to maintain the README.Checklist:
notebooks/pre-commitand addressed any issues not automatically fixeddevREADMEs