Moving to Ruff and pyproject.toml

[HarrisonWilde]

Fixes #195 and fixes #196 (they are pretty closely linked here). Not quite passing all tests but have switched fully to ruff and as a result ditched most of the other config files.

I cannot for the life of me get all tests to pass, because of weird issues in the makefile I have begun to address (This also fixes #203), one of which is the bug in the conda-remove step but now I cannot get the pre-commit hooks and install to work at the same time, seems to be some issue with conda on my system.

Main things to discuss before full PR are:

1. Resolving the issues w the tests (and we may want to add more at some point but for now these seem to work ok)
2. How precisely we want to use Ruff, you can see that I have pretty much kept in line with the old ways with a few changes like standard line length (88 from 80) and fewer ignores + standard isort, etc.

---

Checklist:

• Updated documentation
• CI passes
• Labelled PR major/minor/patch

[HarrisonWilde]

Checks now pass here, but still not on my machine, would be good to figure this out as my setup is fairly standard iiuc.

[caldwellst]

Okay, just a few comments for the moment. I need to install conda and then will run the tests and test out spinning up a project using the cookiecutter.

[caldwellst]

I am unable to locally pass test_precommit(). Everything else is successful. Potentially something with my conda setup, but haven't used it in at least 5 years, so not particularly sure how to troubleshoot.

../../../miniconda3/lib/python3.10/subprocess.py:526: CalledProcessError
--------------------------------------------------------------------- Captured stdout call ---------------------------------------------------------------------
Installing and configuring git pre-commit hooks/bin/bash: /Users/seth.caldwell/miniconda3/envs/nestatestcookie/bin/pre-commit: /Users/seth.caldwell/miniconda3/envs/nestatestcookie/bin/python3.10: bad interpreter: No such file or directory
Git pre-commit setup failed, check .cookiecutter/state/setup-git.log for more info

@HarrisonWilde Have you been able to get all checks passing locally?

[HarrisonWilde]

I am unable to locally pass test_precommit(). Everything else is successful. Potentially something with my conda setup, but haven't used it in at least 5 years, so not particularly sure how to troubleshoot.

../../../miniconda3/lib/python3.10/subprocess.py:526: CalledProcessError
--------------------------------------------------------------------- Captured stdout call ---------------------------------------------------------------------
Installing and configuring git pre-commit hooks/bin/bash: /Users/seth.caldwell/miniconda3/envs/nestatestcookie/bin/pre-commit: /Users/seth.caldwell/miniconda3/envs/nestatestcookie/bin/python3.10: bad interpreter: No such file or directory
Git pre-commit setup failed, check .cookiecutter/state/setup-git.log for more info

@HarrisonWilde Have you been able to get all checks passing locally?

Mine actually fails locally too, I am not sure if I ever got that one working but it works fine on the CI so I stopped trying. I have a feeling it is related to the test itself which may be wrong (could also be due to the addition of the ruff step, perhaps something in the generated repo doesn't pass? I have tried to test this locally and it isn't the case but it is hard to say).

[caldwellst]

Overall, everything looks good. I can't resolve the tests, but also can't resolve the tests in the base master branch, so not too concerned there. Will need to be a wider look at tests at some point in the future.

To me, the settings you've put in place for ruff make sense, but probably those who have worked on previous projects will have more concrete input, particularly on docstring styling or particular approaches we use here.

[caldwellst]

Looks like a reasonable selection! Will be mainly interested how people using the current code base feel. Particularly around mandating a docstring convention? But I am all for it!

[HarrisonWilde]

Yeah, I noticed that was enabled in current flake8 config, I don't usually support those but just tried to stay close for now

[caldwellst]

Yes please!