Improve pre-commit-config.yaml to utilise versioned repos rather than local #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrisonWilde
changed the title
caldwellst
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Simple, and nothing to change in the minor code review I've done. Just a question: should we consider just throwing in pre-commit-update in this PR? Basically setting forth that not only will we use versioned repos for pre-commits, but essentially enforce incremental, shared versioning across all repos by always using the latest? Something to discuss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #193 by updating the pre-commit-config yaml files to use versioned repos. Local is a bad idea for reproducibility and it leads to excessive dependency trees. The performance will be a lot better once we use ruff etc. anyway and in general pre commit hooks should be kept to a minimum. This PR does not aim to tackle that, just update the way in which pre-commit hooks are installed.
Checklist: