-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NGSTACK-805: async indexing #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pspanja
requested review from
emodric,
hknezevic,
iherak,
RandyCupic,
PetraMiseta,
igorkrz and
ludwig031
November 13, 2023 13:39
emodric
reviewed
Nov 14, 2023
emodric
reviewed
Nov 14, 2023
emodric
reviewed
Nov 14, 2023
emodric
reviewed
Nov 14, 2023
lib/Core/Search/Common/Messenger/MessageHandler/Search/Content/CopyContentHandler.php
Show resolved
Hide resolved
igorkrz
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements support for asynchronous indexing through Symfony's Messenger component. Implementation of indexing event listeners from Ibexa core is used as a base for this implementation, but it's improved to take into account the possibility of failure as a part of normal operation. It's mostly about handling the case when Content/Location that should be processed was deleted and hence can't be loaded from the Repository at the time of processing.
Example configuration for the Messenger component is here given as a reference point.
In order to enable asynchronous indexing in a project, a following configuration is needed:
Additionally a consumer processing the asynchronous indexing queue should be running, with the provided example configuration:
bin/console messenger:consume netgen_ibexa_asynchronous_indexing
Indexing command is not modified, meaning it works aside from the asynchronous mechanism.